Repository navigation
Preserve element identity in map over sparse transposes and adjoints - #977
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #977 +/- ##
=======================================
Coverage 94.83% 94.83%
=======================================
Files 16 16
Lines 9248 9248
=======================================
Hits 8770 8770
Misses 478 478 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ViralBShah
added a commit
that referenced
this pull request
Oct 9, 2026
…ember (#1017) Documentation only, drawn from the pull requests merged since early September and their review comments. - **PR text.** The rule against reporting routine checks is its own bullet and names the forms that still got through: test modes passing, the ambiguity check, the Julia build, pass counts. Titles fit one line of `git log --oneline`. - **Added.** Julia's CI flags, `--depwarn=error` and the trim test (#971, #972); dense results where every entry would be stored (#1004, #1005, #1007); opaque elements (#982, #977, #1006); fixed test inputs and `mismatch` (#991, #998). - **Removed.** Rules that Aqua, `.gitignore` or #990 made unnecessary, and test detail that `test/AGENTS.md` already holds. - **`src/solvers/`.** Caller-owned solve workspaces (#914), copying an aliased right-hand side (#942), validating before a refactorization (#899, #901). Corrects the lock field names and the index-type testing rule. - **`test/`.** Fixed inputs and top-level helper loading (#971); drops the notes on worker groups, which `runtests.jl` no longer has. - **`gen/`.** Header order, and running `make` before a change (#1003). Written by Claude Code (Claude Opus 5.5). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Viral B. Shah <ViralBShah@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a regression introduced by #892:
mapover a sparse transpose or adjoint copied every stored element before calling the mapping function. This broke aliases for mutable elements and threwMethodError: copy(::T)for elements that support transposition but not copying.Before (
main)After
Use
ftransposewith the wrapper'stransposeoradjointoperation to materialize the sparse structure while preserving references to its elements, then apply the existing mapping kernel. This retains stored zeros and the sparse traversal introduced in #892. Regression coverage uses the sharedCountedReadshelper to check element identity and the absence of reads to copy block contents, with real and complex matrix blocks for both wrappers.Also update the trim app's Boolean-mask check for #892's stored-zero behavior:
Ai .> 2keeps all four stored entries, whilecountstill returns three.Written by Codex.