Skip to content

Compile Progress - #1140

Open
NeeEoo wants to merge 4 commits into
HaxeFoundation:masterfrom
NeeEoo:progress
Open

NeeEoo wants to merge 4 commits into
HaxeFoundation:masterfrom
NeeEoo:progress

Conversation

@NeeEoo

@NeeEoo NeeEoo commented Aug 2, 2024

Copy link
Copy Markdown
Contributor

This changes the compile header to be

Compiling group: haxe (2997 files)

and adds a small tag saying the progress of the compilation

Skärmavbild 2024-08-02 kl  12 57 15

@SorbetLover

Copy link
Copy Markdown

Bro is cooking

@MAJigsaw77

Copy link
Copy Markdown
Contributor

I think it should look better if you don't add that space when is for example [ 0.8%].

@Simn

Simn commented Aug 18, 2024

Copy link
Copy Markdown
Member

The space is important for alignment:

[9.8%]
[9.9%]
[10.0%] <-- asdf

@ghost

ghost commented Aug 29, 2024 •

Copy link
Copy Markdown

and it'd better if it print num file(s) instead of num files

@MRK2009

MRK2009 commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

@Aidan63 Sorry for bothering you, but do you think you can merge it, since Ne_Eo isn't fixing the space problem due to inactivities and some dramas?
I think I could fix it myself, so it won't look bad.

dimensionscape added a commit to openfl/libhxcpp that referenced this pull request Oct 15, 2026
Each group now says how many files it compiles, and each file, as it
starts, how many of the group's files have finished, as [3/40]. The
count goes up when a compile completes, under the log lock, so it holds
with several compile threads, and it shows with one thread too.

Based on HaxeFoundation/hxcpp#1140 by @NeeEoo and
HaxeFoundation/hxcpp#1423 by @MRK2009

Fixes #38
dimensionscape added a commit to openfl/libhxcpp that referenced this pull request Oct 15, 2026
Each group now says how many files it compiles, and each file, as it
starts, how many of the group's files have finished, as [3/40]. The
count goes up when a compile completes, under the log lock, so it holds
with several compile threads, and it shows with one thread too.

Based on HaxeFoundation/hxcpp#1140 by @NeeEoo and
HaxeFoundation/hxcpp#1423 by @MRK2009

Fixes #38
dimensionscape added a commit to openfl/libhxcpp that referenced this pull request Oct 15, 2026
Each group now says how many files it compiles, and each file, as it
starts, how many of the group's files have finished, as [3/40]. The
count goes up when a compile completes, under the log lock, so it holds
with several compile threads, and it shows with one thread too.

Based on HaxeFoundation/hxcpp#1140 by @NeeEoo and
HaxeFoundation/hxcpp#1423 by @MRK2009

Fixes #38
dimensionscape added a commit to openfl/libhxcpp that referenced this pull request Oct 15, 2026
Each group now says how many files it compiles, and each file, as it
starts, how many of the group's files have finished, as [3/40]. The
count goes up when a compile completes, under the log lock, so it holds
with several compile threads, and it shows with one thread too.

Based on HaxeFoundation/hxcpp#1140 by @NeeEoo and
HaxeFoundation/hxcpp#1423 by @MRK2009

Fixes #38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants