Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017PFWnN1YCH8j2PfdAAZiNY
|
Thanks for the pull request, @TPAteeq. A maintainer will review it soon. Want to talk it through while it is in review? Come join us on our Discord server. For longer-form discussion there is also GitHub Discussions. A couple of things that speed up review: make sure the test suite passes on Python 3.11 and 3.13, and that the change keeps extraction deterministic. |
There was a problem hiding this comment.
Graphify code review 
Reviewed · c60eea01cf87
Tightens the minimum supported Python version to 3.11.5 and refreshes the lockfile for that floor, simplifying version-specific dependency resolution and dropping the now-unneeded async-timeout dependency.
Worth a look (1)
Python 3.11.0–3.11.4 are no longer supported by the lock — uv.lock:4 · Escalate · medium
Detailed review · not verified
- unverified hypothesis — survived the adversarial refute pass; needs human review
Code graph and static checks · 1 function depends on this change
Impact & health
Impact — 1 function depends on the 1 function this change touches.
Health — grade A; no new coupling hotspots.
Formal checks — 1 function this change can affect wasn't formally checked in this review. Formal checks are informational only.
Gate & verification
✅ PASS — objectively clean (no health regressions, tests not run — proofs not run this pass (advisory)). Grounded, not self-assessed.
Advisory (not blocking):
- verification_scope: 1 function(s) in the blast radius were not formally verified this run
Test selection
593 of 593 test file(s) selected (100%) via static blast radius.
Escalated to a full run for safety (
noncode-change,uncovered-code) — the selection is not trustworthy on its own (see below). CI should run the whole suite.
tests/pi.test.ts— full-run-safetytests/test_4874_jvm_resolution.py— full-run-safetytests/test_4909_reference_binding_scale.py— full-run-safetytests/test_4978_reconcile_cost.py— full-run-safetytests/test_4992_ts_import_types.py— full-run-safetytests/test_5072_splittable_under_cap_retry.py— full-run-safetytests/test_affected_cli.py— full-run-safetytests/test_affected_defines.py— full-run-safetytests/test_affected_member_seed.py— full-run-safetytests/test_affected_overrides.py— full-run-safetytests/test_affected_path_file_node.py— full-run-safetytests/test_affected_seed_reference_forms.py— full-run-safetytests/test_agents_platform.py— full-run-safetytests/test_alias_folding.py— full-run-safetytests/test_analyze.py— full-run-safetytests/test_anthropic_custom_endpoint.py— full-run-safetytests/test_antigravity_install.py— full-run-safetytests/test_apm_fallback_version.py— full-run-safetytests/test_architecture_doc.py— full-run-safetytests/test_astro_extraction.py— full-run-safetytests/test_astro_import_ids.py— full-run-safetytests/test_atomic_canvas_export.py— full-run-safetytests/test_atomic_version_stamp.py— full-run-safetytests/test_atomic_writes.py— full-run-safetytests/test_backend_env_isolation.py— full-run-safetytests/test_backend_extras.py— full-run-safetytests/test_backend_opt_in.py— full-run-safetytests/test_benchmark.py— full-run-safetytests/test_benchmark_raw_graph.py— full-run-safetytests/test_benchmark_real_query.py— full-run-safetytests/test_binary_media_words.py— full-run-safetytests/test_blade_extractor.py— full-run-safetytests/test_build.py— full-run-safetytests/test_build_located_semantic_identity.py— full-run-safetytests/test_build_merge_dedup_scope.py— full-run-safetytests/test_build_merge_ghost_fold_4955.py— full-run-safetytests/test_build_merge_hyperedges_and_prune.py— full-run-safetytests/test_build_merge_shrink_guard.py— full-run-safetytests/test_builtin_global_type_refs.py— full-run-safetytests/test_c_include_resolution.py— full-run-safetytests/test_cache.py— full-run-safetytests/test_cache_long_paths.py— full-run-safetytests/test_cache_stale_import_target.py— full-run-safetytests/test_cache_windows_case_4925.py— full-run-safetytests/test_callflow_html.py— full-run-safetytests/test_cargo_introspect.py— full-run-safetytests/test_cargo_missing_manifest.py— full-run-safetytests/test_carried_hyperedge_remap.py— full-run-safetytests/test_case_only_decl_ids_4904.py— full-run-safetytests/test_case_sensitive_resolution.py— full-run-safety- … and 543 more
⚠️ non-code file(s) changed (pyproject.toml,uv.lock) → running the full suite for safety (a code graph can't see config/fixture/data deps)
⚠️ changed code file(s) with no mapped test (pyproject.toml) — a coverage gap or a missing link — running the full suite rather than only the selected tests
Selection is safe under the controlled-regression assumption; always-run tests + a periodic full run are the backstops. Advisory — it never changes the check verdict.
Clears the 3 open Dependabot soupsieve alerts (2 high, 1 medium; all versions < 4.0.0 are affected).
Every patched soupsieve (3.0+) requires Python >= 3.11.5. The lock had kept 2.10 for 3.11.0-3.11.4, so
requires-pythongoes from>=3.11to>=3.11.5. That drops 3.11.0-3.11.4 (2023 patch releases). CI uses "3.11", which resolves to the newest 3.11.x, so it is unaffected. soupsieve only arrives through markdownify -> beautifulsoup4 (pdf/all extras).Checked: lock resolves to a single soupsieve 4.1.1; 492 ingest/markdown/html/pdf tests pass on 3.12; bs4 CSS select + markdownify smoke with the pdf extra.
Note: this changes published package metadata. Fold it into the next release.
🤖 Generated with Claude Code
https://claude.ai/code/session_017PFWnN1YCH8j2PfdAAZiNY