Repository navigation
General cleanup - #355
General cleanup#355
Conversation
- wrong-import-order - invalid-name - built-in shadowing
- invalid-name - trailing-whitespaces - line-too-long
- bad-continuation - invalid-name - wrong-import-order
- bad-continuation - consider-merging-isinstance - fixme - invalid-name - redefined-builtin
- invalid-name - redefined-builtin - wrong-import-order
- invalid-name
- invalid-name - line-too-long - redefined-builtin
- pointless-string-statement - invalid-name
- line-too-long - bad-continuation - invalid-name - consider-merging-isinstance
- consider-merging-isinstance - no-else-return - invalid-name - redefined-builtin (format)
- fixme - invalid-name
- Added travis osx python 3.8 build - Added travis python 3.9dev build with allowed fail - Added appveyor python 3.8 builds
- fixme - invalid-name - line-too-long - trailing-whitespace
- anomalous-backslash-in-string - fixme - invalid-name - line-too-long - trailing-whitespace
achilleas-k
left a comment
There was a problem hiding this comment.
Wonderful PR. A joy to read.
Approving with a bunch of recommended changes for docstring grammar, because when everything else is fine, all that's left is nitpicking grammar.
All the recommendations are for grammatical consistency of docstrings. Most method and property docstrings were consistent in that method docstrings describe an action (e.g., "Checks an input string...") and property docstrings describe the value they return ("The name of the Section"). The changes were for docstrings that don't follow that rule.
achilleas-k
left a comment
There was a problem hiding this comment.
Wonderful PR. A joy to read.
Approving with a bunch of recommended changes for docstring grammar, because when everything else is fine, all that's left is nitpicking grammar.
All the recommendations are for grammatical consistency of docstrings. Most method and property docstrings were consistent in that method docstrings describe an action (e.g., "Checks an input string...") and property docstrings describe the value they return ("The name of the Section"). The changes were for docstrings that don't follow that rule.
Co-Authored-By: Achilleas Koutsou <achilleas.k@gmail.com>
This PR tries to cleanup all minor PEP8 issues in one go. It addresses only issues that do not change any behaviour. From my point of view any future PRs addressing code quality will be easier to review and discuss if they are not mixed with additional minor PEP8 issues.
The PR further tries to now provide full documentation for all relevant classes and functions.
The PR also updates the CI builds to include Python 3.8 on all OS and adds an allowed to fail build for Python 3.9dev on Travis.