Skip to content

fix(antigravity): preserve commands with colliding names - #1673

Open
22nsuk wants to merge 2 commits into
EveryInc:mainfrom
22nsuk:fix/antigravity-command-collisions-1672
Open

22nsuk wants to merge 2 commits into
EveryInc:mainfrom
22nsuk:fix/antigravity-command-collisions-1672

Conversation

@22nsuk

@22nsuk 22nsuk commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #1672.

Use the path returned by the existing uniqueName() helper so normalized command-name collisions do not overwrite earlier prompts. Namespace layout and non-colliding paths stay unchanged.

Validation

Two converter-to-writer regression cases cover flat/namespaced commands, an occupied -2 suffix, and each output's prompt. Both fail before the fix.

GitHub CI is passing as of 2026-10-17 UTC. CI run 38991779197, attempt 1 passed all jobs; the docs build also passed.

  • PR head: 5bd15bcd1f2b57dfee19fbd3d8034498f12ac0e5. This adds only an empty CI-trigger commit after 45f696683019e01556a7501855d276f92e485171: the source tree is unchanged and the PR remains two files, +36/-2. Directly rerunning the old upstream workflow was permission-denied, so the new branch commit triggered a fresh pull-request run.
  • CI checked out merge 48a7bac2a47ea9dcfd2df1f19244001adcfc1bc8 with main 94bda01bd5f7eb6e102c34f3797483aea5fa9b98, tree 44dd122eb967b48c9e7d0fbdfd2f936d2bc3263d.
  • Linux bun run test, verified Bun 1.4.3+c6da4a4d3, 4 workers: 4,583 pass / 10 skip / 0 fail, 4,593 tests across 175 files in 184.17s. Both collision regressions passed. No whole-pass or TimeoutError-file recovery was needed.
  • The default suite skipped nine opt-in acpx-contract cases and the unavailable omp test. The separate acpx-contract job passed. Release metadata, plugin schema, typecheck, Windows native checks, macOS bash 3.2, docs audit, and PR-title checks also passed.
  • Local isolated Linux/WSL validation of the identical merge tree with Bun 1.4.3 and 4 workers passed: 4,583 pass / 10 skip / 0 fail, 111.76s, no recovery.
  • A bounded local 24-worker comparison with unpatched main reproduced the SIGQUIT helper timeout in both main runs and both PR-integration runs. The bounded-wait assertion and subsequent cleanup failure appeared in only one integration run; their attribution remains unresolved. A single green 4-worker run does not establish high-concurrency stability.

Historical context: the 2026-09-28 run on head 45f69668 stalled at the 1200s watchdog on Bun 1.4.2, after #1787. Main later gained #1806 recovery, and Bun 1.4.3 includes upstream oven-sh/bun#44581. The old process snapshot does not prove the exact native root cause; #1784 remains the investigation record.

Security Disclosure

Output-integrity fix only. No changes to permissions, path validation, or skill-directory handling.

Agent Disclosure

Original implementation: ChatGPT · GPT-6 Astra Pro.

CI diagnosis and rebase: Codex · GPT-6. Independent code review: Codex · gpt-6-astra (medium).

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-17T01:41:18.723918Z 5bd15bc New commits
🔒 Security Review ✅ Completed 2026-09-10T22:08:01.781681Z 0f392ea PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@tmchow

tmchow commented Sep 13, 2026

Copy link
Copy Markdown
Collaborator

@22nsuk get CI passing.

@22nsuk
22nsuk force-pushed the fix/antigravity-command-collisions-1672 branch from 0f392ea to 09a1da9 Compare September 13, 2026 15:27
@22nsuk
22nsuk force-pushed the fix/antigravity-command-collisions-1672 branch from 09a1da9 to dcd7d7d Compare September 28, 2026 00:45
@22nsuk

22nsuk commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor Author

@tmchow The earlier CI failure was resolved: run 34765656632 passed. I rechecked against current main e80c5c40 on September 28 by rebasing the unchanged two-file patch; the PR head is now dcd7d7d4.

The new CI run passed PR-title, Windows, macOS bash 3.2, and release/plugin validation. All 18 Antigravity tests, including both collision regressions, passed in the Linux job. However, the full Linux test job stopped producing test output and was cancelled at the 30-minute limit, without a final suite summary or a reported assertion failure. The current overall CI is therefore not green. The docs build passed.

On the same source locally, bun run test passed 4,324 tests with one skip (omp unavailable) and no recovery run; both validators also passed. The PR's original patch is unchanged.

The stalled Linux run appears to match #1784: its last reported result was the same final test (the worker result schema pins terminal and scope-expansion shapes) in tests/skills/ce-work-cross-model-routes.test.ts, at 00:50:33 UTC. No suite summary or recovery-run announcement followed; cancellation occurred at 01:15:27 UTC, and cleanup terminated three orphaned bun processes. All 175 test-file group headers appeared, with no failed test result printed. These are matching symptoms, not proof of which worker failed to exit or of the underlying cause.

Use the path returned by the existing uniqueName helper so normalized
command names cannot overwrite earlier prompts. Keep namespaces and
non-colliding paths unchanged.

Cover flat and namespaced converter-to-writer output, including an
already occupied numeric suffix and preservation of each prompt.

Fixes EveryInc#1672.
@22nsuk
22nsuk force-pushed the fix/antigravity-command-collisions-1672 branch from dcd7d7d to 45f6966 Compare September 28, 2026 16:15
@22nsuk

22nsuk commented Sep 28, 2026

Copy link
Copy Markdown
Contributor Author

@tmchow Rebased the unchanged two-file patch onto current main dd1bf2b8 (including #1787); head is 45f69668. CI run 36449782251 has completed, but CI is still not green.

PR-title, Windows, macOS bash 3.2, release/plugin validation, and the separate docs build passed. All 18 Antigravity tests passed. The Linux suite hit the new 1200s watchdog and failed with a process listing: a surviving Bun worker and a defunct Python child. It was not a 30-minute job cancellation, and no recovery run was attempted. No failed test result printed before the stall.

I posted the diagnostic in #1784 as requested there. This run's 13 missing test results are in doc-claims-validator.test.ts; all 20 ce-work-unit-workspace-init results printed. The underlying cause remains unproven, and #1784 stays open.

Locally, the same head passed bun run test through its existing recovery path: first pass 4,340 pass / 1 skip / 1 TimeoutError, then all 10 tests in the affected harness file passed in a fresh process. Both validators passed. No product-code, CI-setting, or timeout changes were added to this PR.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Antigravity conversion overwrites commands with colliding normalized names

2 participants