Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@22nsuk get CI passing. |
0f392ea to
09a1da9
Compare
09a1da9 to
dcd7d7d
Compare
|
@tmchow The earlier CI failure was resolved: run 34765656632 passed. I rechecked against current main The new CI run passed PR-title, Windows, macOS bash 3.2, and release/plugin validation. All 18 Antigravity tests, including both collision regressions, passed in the Linux job. However, the full Linux test job stopped producing test output and was cancelled at the 30-minute limit, without a final suite summary or a reported assertion failure. The current overall CI is therefore not green. The docs build passed. On the same source locally, The stalled Linux run appears to match #1784: its last reported result was the same final test ( |
Use the path returned by the existing uniqueName helper so normalized command names cannot overwrite earlier prompts. Keep namespaces and non-colliding paths unchanged. Cover flat and namespaced converter-to-writer output, including an already occupied numeric suffix and preservation of each prompt. Fixes EveryInc#1672.
dcd7d7d to
45f6966
Compare
|
@tmchow Rebased the unchanged two-file patch onto current main PR-title, Windows, macOS bash 3.2, release/plugin validation, and the separate docs build passed. All 18 Antigravity tests passed. The Linux suite hit the new 1200s watchdog and failed with a process listing: a surviving Bun worker and a defunct Python child. It was not a 30-minute job cancellation, and no recovery run was attempted. No failed test result printed before the stall. I posted the diagnostic in #1784 as requested there. This run's 13 missing test results are in Locally, the same head passed |
Fixes #1672.
Use the path returned by the existing
uniqueName()helper so normalized command-name collisions do not overwrite earlier prompts. Namespace layout and non-colliding paths stay unchanged.Validation
Two converter-to-writer regression cases cover flat/namespaced commands, an occupied
-2suffix, and each output's prompt. Both fail before the fix.GitHub CI is passing as of 2026-10-17 UTC. CI run 38991779197, attempt 1 passed all jobs; the docs build also passed.
5bd15bcd1f2b57dfee19fbd3d8034498f12ac0e5. This adds only an empty CI-trigger commit after45f696683019e01556a7501855d276f92e485171: the source tree is unchanged and the PR remains two files, +36/-2. Directly rerunning the old upstream workflow was permission-denied, so the new branch commit triggered a fresh pull-request run.48a7bac2a47ea9dcfd2df1f19244001adcfc1bc8with main94bda01bd5f7eb6e102c34f3797483aea5fa9b98, tree44dd122eb967b48c9e7d0fbdfd2f936d2bc3263d.bun run test, verified Bun1.4.3+c6da4a4d3, 4 workers: 4,583 pass / 10 skip / 0 fail, 4,593 tests across 175 files in 184.17s. Both collision regressions passed. No whole-pass or TimeoutError-file recovery was needed.omptest. The separate acpx-contract job passed. Release metadata, plugin schema, typecheck, Windows native checks, macOS bash 3.2, docs audit, and PR-title checks also passed.Historical context: the 2026-09-28 run on head
45f69668stalled at the 1200s watchdog on Bun 1.4.2, after #1787. Main later gained #1806 recovery, and Bun 1.4.3 includes upstream oven-sh/bun#44581. The old process snapshot does not prove the exact native root cause; #1784 remains the investigation record.Security Disclosure
Output-integrity fix only. No changes to permissions, path validation, or skill-directory handling.
Agent Disclosure
Original implementation: ChatGPT · GPT-6 Astra Pro.
CI diagnosis and rebase: Codex · GPT-6. Independent code review: Codex · gpt-6-astra (medium).