Skip to content

Fix CommandLine.template accepting append assignments as the program - #9863

Merged
tim-smart merged 2 commits into
Effect-TS:v4/next-minorfrom
devangpratap:fix/commandline-append-assignment
Oct 26, 2026
Merged

tim-smart merged 2 commits into
Effect-TS:v4/next-minorfrom
devangpratap:fix/commandline-append-assignment

Conversation

@devangpratap

@devangpratap devangpratap commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

The program-position assignment check in CommandLine.template now also matches NAME+=value, so it fails with UnsupportedSyntax like NAME=value does instead of becoming the program name:

CommandLine.template`FOO+=bar make`
// before: Success ["FOO+=bar", "make"]
// after:  Failure UnsupportedSyntax "A variable assignment needs a shell in template part 0"

bash -c 'X+=1 env', zsh -c 'X+=1 env' and macOS sh -c 'X+=1 env' all set X=1. As an argument, make FOO+=bar is still accepted, the same as FOO=bar.

Added FOO+=bar cmd to the "rejects syntax that needs a shell" cases; it fails without the change.

Closes #9862

Closes EFF-2874

@effect-bot
effect-bot force-pushed the fix/commandline-append-assignment branch from acf68c6 to 217c108 Compare October 23, 2026 13:14
@changeset-bot

changeset-bot Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 086141f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 33 packages
Name Type
effect Patch
@effect/opentelemetry Patch
@effect/vitest Patch
@effect/ai-anthropic Patch
@effect/ai-cloudflare Patch
@effect/ai-openai-compat Patch
@effect/ai-openai Patch
@effect/ai-openrouter Patch
@effect/ai-typesafe Patch
@effect/atom-react Patch
@effect/atom-solid Patch
@effect/atom-vue Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-deno Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/sql-clickhouse Patch
@effect/sql-d1 Patch
@effect/sql-libsql Patch
@effect/sql-mssql Patch
@effect/sql-mysql2 Patch
@effect/sql-pg Patch
@effect/sql-pglite Patch
@effect/sql-sqlite-bun Patch
@effect/sql-sqlite-do Patch
@effect/sql-sqlite-node Patch
@effect/sql-sqlite-react-native Patch
@effect/sql-sqlite-wasm Patch
@effect/docgen Patch
@effect/doctest Patch
@effect/graphql-generator Patch
@effect/openapi-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Bundle Size Analysis

Generated from PR build output; treat the content below as untrusted.

File Name Current Size Previous Size Difference
arbitrary-combinators.ts 39.31 KB 39.31 KB 0.00 KB (0.00%)
basic.ts 7.17 KB 7.17 KB 0.00 KB (0.00%)
batching.ts 11.04 KB 11.04 KB 0.00 KB (0.00%)
brand.ts 6.83 KB 6.83 KB 0.00 KB (0.00%)
cache.ts 11.47 KB 11.47 KB 0.00 KB (0.00%)
config.ts 22.73 KB 22.73 KB 0.00 KB (0.00%)
differ.ts 21.86 KB 21.86 KB 0.00 KB (0.00%)
http-client.ts 26.70 KB 26.70 KB 0.00 KB (0.00%)
http-router.ts 36.64 KB 36.64 KB 0.00 KB (0.00%)
logger.ts 11.86 KB 11.86 KB 0.00 KB (0.00%)
metric.ts 9.40 KB 9.40 KB 0.00 KB (0.00%)
optic.ts 7.04 KB 7.04 KB 0.00 KB (0.00%)
pubsub.ts 15.95 KB 15.95 KB 0.00 KB (0.00%)
queue.ts 12.75 KB 12.75 KB 0.00 KB (0.00%)
schedule.ts 11.72 KB 11.72 KB 0.00 KB (0.00%)
schema-bigdecimal.ts 13.98 KB 13.98 KB 0.00 KB (0.00%)
schema-binary.ts 41.02 KB 41.02 KB 0.00 KB (0.00%)
schema-class.ts 21.52 KB 21.52 KB 0.00 KB (0.00%)
schema-fromJsonSchemaDocument.ts 29.49 KB 29.49 KB 0.00 KB (0.00%)
schema-representation-roundtrip.ts 27.87 KB 27.87 KB 0.00 KB (0.00%)
schema-string-transformation.ts 15.24 KB 15.24 KB 0.00 KB (0.00%)
schema-string.ts 12.22 KB 12.22 KB 0.00 KB (0.00%)
schema-template-literal.ts 16.16 KB 16.16 KB 0.00 KB (0.00%)
schema-toArbitrary.ts 38.85 KB 38.85 KB 0.00 KB (0.00%)
schema-toCodeDocument.ts 26.05 KB 26.05 KB 0.00 KB (0.00%)
schema-toCodecJson.ts 20.79 KB 20.79 KB 0.00 KB (0.00%)
schema-toEquivalence.ts 20.94 KB 20.94 KB 0.00 KB (0.00%)
schema-toFormatter.ts 21.04 KB 21.04 KB 0.00 KB (0.00%)
schema-toJsonSchemaDocument.ts 26.07 KB 26.07 KB 0.00 KB (0.00%)
schema-toRepresentation.ts 21.12 KB 21.12 KB 0.00 KB (0.00%)
schema.ts 20.72 KB 20.72 KB 0.00 KB (0.00%)
stm.ts 14.06 KB 14.06 KB 0.00 KB (0.00%)
stream.ts 10.31 KB 10.31 KB 0.00 KB (0.00%)

@effect-bot
effect-bot force-pushed the v4/next-minor branch 3 times, most recently from 790c162 to d8f433d Compare October 25, 2026 17:43
@effect-bot
effect-bot force-pushed the v4/next-minor branch 2 times, most recently from 0dfd080 to e75d84d Compare October 26, 2026 20:48
@effect-bot
effect-bot force-pushed the fix/commandline-append-assignment branch from e3cf2f1 to 39f4ea2 Compare October 26, 2026 21:56
@tim-smart
tim-smart enabled auto-merge (squash) October 26, 2026 21:59
@effect-bot
effect-bot force-pushed the fix/commandline-append-assignment branch from 39f4ea2 to 086141f Compare October 26, 2026 22:18
@tim-smart
tim-smart merged commit 55d5158 into Effect-TS:v4/next-minor Oct 26, 2026
12 of 19 checks passed
@effect-bot effect-bot mentioned this pull request Oct 26, 2026
tim-smart pushed a commit that referenced this pull request Oct 26, 2026
effect-bot added a commit that referenced this pull request Oct 26, 2026
tim-smart pushed a commit that referenced this pull request Oct 27, 2026
effect-bot added a commit that referenced this pull request Oct 27, 2026
effect-bot added a commit to yordis/effect that referenced this pull request Oct 27, 2026
effect-bot added a commit that referenced this pull request Oct 27, 2026
effect-bot added a commit that referenced this pull request Oct 27, 2026
effect-bot added a commit that referenced this pull request Oct 27, 2026
tim-smart pushed a commit that referenced this pull request Oct 27, 2026
effect-bot added a commit that referenced this pull request Oct 27, 2026
effect-bot added a commit that referenced this pull request Oct 27, 2026
tim-smart pushed a commit that referenced this pull request Oct 27, 2026
tim-smart pushed a commit that referenced this pull request Oct 27, 2026
effect-bot added a commit that referenced this pull request Oct 27, 2026
effect-bot added a commit that referenced this pull request Oct 27, 2026
tim-smart pushed a commit that referenced this pull request Oct 27, 2026
effect-bot added a commit that referenced this pull request Oct 27, 2026
effect-bot added a commit to wmaurer/effect that referenced this pull request Oct 27, 2026
effect-bot added a commit to wmaurer/effect that referenced this pull request Oct 27, 2026
effect-bot added a commit to wmaurer/effect that referenced this pull request Oct 27, 2026
effect-bot added a commit to wmaurer/effect that referenced this pull request Oct 27, 2026
effect-bot added a commit to wmaurer/effect that referenced this pull request Oct 28, 2026
effect-bot added a commit to wmaurer/effect that referenced this pull request Oct 28, 2026
effect-bot added a commit to wmaurer/effect that referenced this pull request Oct 28, 2026
effect-bot added a commit to wmaurer/effect that referenced this pull request Oct 28, 2026
effect-bot added a commit that referenced this pull request Oct 28, 2026
effect-bot added a commit to wmaurer/effect that referenced this pull request Oct 28, 2026
effect-bot added a commit that referenced this pull request Oct 28, 2026
tim-smart pushed a commit that referenced this pull request Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants