Repository navigation
Keep maxDepth in Context.pick and slim Context.makeUnsafe - #9837
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 12b8ed0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 33 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
Merged
tim-smart
added a commit
that referenced
this pull request
Oct 24, 2026
effect-bot
pushed a commit
to jayhemnani9910/effect
that referenced
this pull request
Oct 24, 2026
effect-bot
pushed a commit
that referenced
this pull request
Oct 25, 2026
effect-bot
pushed a commit
to FredAmartey/effect
that referenced
this pull request
Oct 25, 2026
tim-smart
added a commit
that referenced
this pull request
Oct 26, 2026
effect-bot
pushed a commit
that referenced
this pull request
Oct 26, 2026
effect-bot
pushed a commit
that referenced
this pull request
Oct 26, 2026
tim-smart
added a commit
that referenced
this pull request
Oct 26, 2026
effect-bot
pushed a commit
that referenced
this pull request
Oct 26, 2026
tim-smart
added a commit
that referenced
this pull request
Oct 27, 2026
effect-bot
pushed a commit
that referenced
this pull request
Oct 27, 2026
effect-bot
pushed a commit
that referenced
this pull request
Oct 27, 2026
effect-bot
pushed a commit
that referenced
this pull request
Oct 27, 2026
effect-bot
pushed a commit
that referenced
this pull request
Oct 27, 2026
effect-bot
pushed a commit
that referenced
this pull request
Oct 27, 2026
tim-smart
added a commit
that referenced
this pull request
Oct 27, 2026
effect-bot
pushed a commit
that referenced
this pull request
Oct 27, 2026
effect-bot
pushed a commit
that referenced
this pull request
Oct 27, 2026
tim-smart
added a commit
that referenced
this pull request
Oct 27, 2026
tim-smart
added a commit
that referenced
this pull request
Oct 27, 2026
effect-bot
pushed a commit
that referenced
this pull request
Oct 27, 2026
effect-bot
pushed a commit
that referenced
this pull request
Oct 27, 2026
tim-smart
added a commit
that referenced
this pull request
Oct 27, 2026
effect-bot
pushed a commit
that referenced
this pull request
Oct 27, 2026
effect-bot
pushed a commit
that referenced
this pull request
Oct 27, 2026
effect-bot
pushed a commit
to wmaurer/effect
that referenced
this pull request
Oct 27, 2026
effect-bot
pushed a commit
to wmaurer/effect
that referenced
this pull request
Oct 27, 2026
effect-bot
pushed a commit
to wmaurer/effect
that referenced
this pull request
Oct 27, 2026
effect-bot
pushed a commit
to wmaurer/effect
that referenced
this pull request
Oct 28, 2026
effect-bot
pushed a commit
to wmaurer/effect
that referenced
this pull request
Oct 28, 2026
effect-bot
pushed a commit
to wmaurer/effect
that referenced
this pull request
Oct 28, 2026
effect-bot
pushed a commit
to wmaurer/effect
that referenced
this pull request
Oct 28, 2026
effect-bot
pushed a commit
that referenced
this pull request
Oct 28, 2026
effect-bot
pushed a commit
to wmaurer/effect
that referenced
this pull request
Oct 28, 2026
effect-bot
pushed a commit
that referenced
this pull request
Oct 28, 2026
tim-smart
added a commit
that referenced
this pull request
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8969 added
maxDepthtoContext.makeUnsafeand made thebasic.tsbundle fixture larger. It also left a gap inContext.pick: with zero or one key it reset the result to the default depth of 8 instead of keeping the source context'smaxDepth.Changes
makeUnsafechecksmaxDepthinline instead of callingnormalizeMaxDepth, whose default parameter kept it in the bundle. When no options are passed, Rollup can now reduce the argument to8. Behaviour is unchanged: NaN, Infinity, negative and non-integer values still fall back to 8.pickfast path for zero or one key now carries over the source context'smaxDepth, which matches the JSDoc.pickwith zero and one key.Bundle size
basic.tsagainstv4/next-minor(fcb9610134): 7194 B → 7165 B gzip (−0.03 KB).Closes EFF-2859