Repository navigation
Migrate apps and e2e to vitest - #36268
Open
GoodDayForSurf wants to merge 6 commits into
Open
GoodDayForSurf wants to merge 6 commits into
GoodDayForSurf wants to merge 6 commits into
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The Angular builder and browser-test migration needs build and Chromium-backed test validation, but unavailable dependencies and the playground’s exclusion from default CI tests leave runtime compatibility unverified.
No open issues 🎉
1 file not reviewed
pnpm-lock.yaml: Generated file
What changed in this PR
Migrates the Angular sandbox’s unit tests from Karma/Jasmine to Vitest with Playwright-backed Chromium, and removes legacy Karma test configuration from the wrapper end-to-end harness.
Changes:
- Switches the Angular sandbox to
@angular/buildand its Vitest test runner. - Removes obsolete Karma/Jasmine dependencies, configuration, and test bootstrap files.
- Updates workspace dependency records, test typings, and Angular cache ignores.
| File | Description |
|---|---|
pnpm-workspace.yaml |
Adds shared Playwright and Angular build dependencies. |
pnpm-lock.yaml |
Records the updated test tooling dependency graph. |
e2e/wrappers/package.json |
Removes Karma/Jasmine dependencies. |
e2e/wrappers/builders/angular/tsconfig.spec.json |
Deletes the Jasmine test TypeScript configuration. |
e2e/wrappers/builders/angular/angular.json |
Removes the Karma test target. |
apps/angular/tsconfig.spec.json |
Configures Vitest globals and removes the old bootstrap reference. |
apps/angular/src/tsconfig.app.json |
Removes the exclusion for the deleted test bootstrap. |
apps/angular/src/test.ts |
Deletes the Karma test bootstrap. |
apps/angular/package.json |
Adds Vitest, Playwright, and @angular/build. |
apps/angular/karma.conf.js |
Deletes the Karma runner configuration. |
apps/angular/angular.json |
Configures Angular build targets and headless Vitest tests. |
apps/angular/.gitignore |
Ignores the Angular cache directory. |
Review effort: Balanced
…main_replaceKarma_by_vitest_e2e_apps # Conflicts: # pnpm-lock.yaml
….com/GoodDayForSurf/DevExtreme into main_replaceKarma_by_vitest_e2e_apps
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The Angular test runner resolves to Vite 8.3.4, which falls outside Vitest and its mocker’s declared ^7.3.7 peer range, leaving a required dependency incompatibility.
1 open issue
1 file not reviewed
pnpm-lock.yaml: Generated file
Review effort: Balanced
ajivanyandev
approved these changes
Nov 13, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Changes
Removes the remaining Karma/Jasmine usage outside of
devextreme-angular.apps/angular: unit tests switch from the Karma builder to the Angularunit-testbuilder with the Vitest runner.e2e/wrappers: the unused Karmatesttarget and its dependencies are removed.How
apps/angular:@angular-devkit/build-angularto@angular/build(application,dev-server,unit-test).testbuild configuration is added (no optimization, source maps, JIT) and used as thebuildTargetof thetesttarget. Tests run inChromiumHeadless.karma.conf.jsandsrc/test.tsare deleted;tsconfig.spec.jsonusesvitest/globalstypes instead ofjasmine.vitest,@vitest/browser-playwrightandplaywrightare added;@types/jasmineis removed.e2e/wrappers:testtarget is removed frombuilders/angular/angular.jsontogether withtsconfig.spec.json.@types/jasminedevDependencies are removed.Workspace:
@angular/buildis added to theangularcatalog andplaywrightto the default catalog.