Skip to content

Check the delete permission when deleting an engagement preset - #16974

Open
svader0 wants to merge 1 commit into
DefectDojo:devfrom
svader0:harden-engagement-preset-delete-check
Open

svader0 wants to merge 1 commit into
DefectDojo:devfrom
svader0:harden-engagement-preset-delete-check

Conversation

@svader0

@svader0 svader0 commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

Deleting an engagement preset now checks the same permission as deleting an engagement, instead of the edit permission. Adds a regression test. No change for users who can already delete engagements.

Deleting a preset now needs the same permission as deleting an
engagement. Adds a regression test.
@dryrunsecurity

Copy link
Copy Markdown

DryRun Security

This pull request modifies a sensitive authorization file by an author who is not on the allowed list. However, this finding is classified as low severity and is not blocking.

Configured Sensitive Codepath Modified by Non-Allowed Author in dojo/authorization/api_permissions.py (drs_f363e40c)
Vulnerability Configured Sensitive Codepath Modified by Non-Allowed Author
Description File 'dojo/authorization/api_permissions.py' matches configured sensitive codepath pattern 'dojo/authorization/*.py' and was modified by 'svader0' (commit 5b900cc) who is not in the allowed authors list.

Comment to provide feedback on these findings.

Report false positive: @dryrunsecurity fp [FINDING ID] [FEEDBACK]
Report low-impact: @dryrunsecurity nit [FINDING ID] [FEEDBACK]

Example: @dryrunsecurity fp drs_90eda195 This code is not user-facing

All finding details can be found in the DryRun Security Dashboard.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant