Repository navigation
Boot order handling - #111
Merged
WillNilges merged 8 commits intoNov 12, 2021
Merged
Conversation
Update boot order parsing so as to be compatible with the new Proxmox syntax for virtual machine boot device ordering. Maintain support for the deprecated boot device order syntax. Virtual machines using the deprecated syntax are not updated to use the new syntax.
This reverts commit d44698a.
Create a method to get the drives attached to a vm that have media type cdrom.
Propose new boot order to owners of VMs that exist on nodes running Proxmox version 6.3 or greater. Instead of returning the legacy boot order to the UI, a new boot order is created and sent instead. The new order mimics the old order, but is compliant with the new format. The new order will take effect only if the user explicitly updates.
Change format of the VM boot order JSON. This new format allows
the UI to mimic the Proxmox boot order selection system.
The new format is as follows
{
'legacy': False,
'order': [
{
'device': 'virtio0',
'description': 'local-lvm:vm-102-disk-0,size=8G',
'enabled': True
},
...
]
}
Update the UI boot order selection element. It has been modified to support the new 'order=' format for the Proxmox boot order option in a more intuitive way for the user. The new element allows users to enable any bootable device and choose the order for these devices to boot in. The new UI element is a table with four columns. The first column indicates the order of the corresponding device. The second column indicates whether the device is enabled as bootable. The third column contains the device name. The fourth column contains the device description. The order of the columns is changed by dragging, enabled by SortableJS. In cases of legacy nodes, the older dropdown boxes are used.
Disabled boot devices will no longer show up in the boot order display on the vm details page in the resources section.
WillNilges
self-requested a review
September 27, 2021 05:43
galenguyer
approved these changes
Sep 28, 2021
Member
|
I'd like to get this working on my local machine before we merge this, if I can actually find a single second in my day to actually do so. |
WillNilges
reviewed
Oct 2, 2021
| }) | ||
| ); | ||
| row.insertCell().innerHTML = boot_order.order[i].device; | ||
| row.insertCell().innerHTML = boot_order.order[i].description; |
Member
There was a problem hiding this comment.
According to @harmonherring the boot order selection menu descriptions break the view on mobile devices.
WillNilges
approved these changes
Oct 2, 2021
WillNilges
left a comment
Member
There was a problem hiding this comment.
I have verified that the changes work. @harmonherring has a known issue with the mobile view that he'll fix. As soon as that's pushed, I'll merge this PR.
Member
|
So, not having this is causing a lot of issues in Proxstar right now. Gonna merge this to make it stop dying. @galenguyer and I aren't 100% sure if it'll help, but ¯\_(ツ)_/¯ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #85
May need adjustments for mobile devices, possibly remove device description in the selection modal