Skip to content

Fix CaDoodle STEP face continuity and solid topology - #81

Open
KacperLa wants to merge 1 commit into
developmentfrom
codex/cadoodle-step-solid-boundaries-20261120
Open

KacperLa wants to merge 1 commit into
developmentfrom
codex/cadoodle-step-solid-boundaries-20261120

Conversation

@KacperLa

Copy link
Copy Markdown

CaDoodle STEP exports could fragment the nametag’s coplanar region and leave the box-minus-sphere fixture as 13 open shells. This fixes both while keeping production export one-shot.

  • Keep analytic face growth within reader plane resolution, apply coherent mesh snapping instead of late vertex-ID aliasing, and retain AP242 tessellation as one physical part.
  • Conform BSP boundary segment chains before BRep grouping and tessellation. Correct fallback accounting, rescore after each replacement, and require exactly one forward/reverse boundary use; balanced 2:2 uses are nonmanifold.
  • Preserve development’s existing thin-triangle and plane-refit work. Restore the disabled BRep coverage class and add regressions for the measured seam, plane drift, vertex identity, asymmetric chains, genuine gaps and conflicting fallbacks.

Validated on this branch, based on development 8ea109f, using Mac x64, Zulu JavaFX 25, Gradle 9.1.0 and FreeCAD 1.1.3 / OCCT 7.8.1:

  • Offline focused/surrounding tests: 25 passed, 13 existing method skips; the restored BRep class’s three active tests pass. Original coverage method also passes alone.
  • Both actual CSG → STEP → FreeCAD → 3MF → CSG cycles: one valid solid/closed shell, structural gate exit 0, watertight raw meshes without self-intersections, all six bounds within 1e-5 mm.
  • Nametag seam absent; all 194 / 7,192 emitted directed boundaries have exact 1:1 incidence.

Screenshots omitted because offscreen FreeCAD viewport export crashed. No desktop captures or local evidence files are published.

@KacperLa
KacperLa marked this pull request as ready for review November 20, 2026 22:46

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant