Skip to content

Unbind markdown haxelib from STRIPPED_COMPILE haxedef - #1168

Open
r6915ee wants to merge 3 commits into
CodenameCrew:mainfrom
r6915ee:build/stripped-compile-markdown
Open

r6915ee wants to merge 3 commits into
CodenameCrew:mainfrom
r6915ee:build/stripped-compile-markdown

Conversation

@r6915ee

@r6915ee r6915ee commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

Stripped compiling was recently broken, because the markdown haxelib wasn't included due to STRIPPED_COMPILE disabling it while MarkdownUtil was making use of it. The pull request just removes the binding so that stripped compiling can work again.

@Raltyro Raltyro added the status:invalid This doesn't seem right label Oct 19, 2026
@Raltyro

Raltyro commented Nov 1, 2026

Copy link
Copy Markdown
Member

I forgot to say why i put this invalid, i think the intended solution is to make markdown not compiled with stripped_compile

@r6915ee

r6915ee commented Nov 1, 2026

Copy link
Copy Markdown
Contributor Author

i think the intended solution is to make markdown not compiled with stripped_compile

I think in that case, it would be better to compile the update screen only when STRIPPED_COMPILE is disabled. That's the only thing using MarkdownUtil in the engine currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:invalid This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants