Skip to content

zSTD Support #35

Closed
Closed

Description

@cliffburdick

Hi, is there a reason zstd support isn't in this client? Would you be willing to accept a PR for it or is there a reason it's purposely left out?

Activity

  1. Enmk commented on Apr 16, 2020

    @Enmk
    Contributor

    Generally, all PRs are welcome. But just to clarify, do you want to implement an additional client-server protocol compression method?

  2. alexey-milovidov commented on Apr 16, 2020

    @alexey-milovidov
    Member

    @Enmk This compression method is already supported in ClickHouse, look at the
    network_compression_method
    network_zstd_compression_level
    settings.

  3. cliffburdick commented on Apr 16, 2020

    @cliffburdick
    Author

    @Enmk This compression method is already supported in ClickHouse, look at the
    network_compression_method
    network_zstd_compression_level
    settings.

    Yes, I should have clarified that it's already supported on the server, and the client is the only one lacking support.

  4. Enmk commented on Apr 19, 2020

    @Enmk
    Contributor

    Great, you are very welcome to add ZSTD support on ClickHouse-cpp side. Also, please make sure to add some tests to the PR 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions