Hi, is there a reason zstd support isn't in this client? Would you be willing to accept a PR for it or is there a reason it's purposely left out?
Activity
Enmk commentedon Apr 16, 2020
Generally, all PRs are welcome. But just to clarify, do you want to implement an additional client-server protocol compression method?
alexey-milovidov commentedon Apr 16, 2020
@Enmk This compression method is already supported in ClickHouse, look at the
network_compression_methodnetwork_zstd_compression_levelsettings.
cliffburdick commentedon Apr 16, 2020
Yes, I should have clarified that it's already supported on the server, and the client is the only one lacking support.
Enmk commentedon Apr 19, 2020
Great, you are very welcome to add ZSTD support on ClickHouse-cpp side. Also, please make sure to add some tests to the PR 🙏