Repository navigation
deps: bump portalocker maximum version to allow v4.x - #154
Open
Jeremy Cline (jeremycline) wants to merge 1 commit into
Open
Jeremy Cline (jeremycline) wants to merge 1 commit into
Jeremy Cline (jeremycline) wants to merge 1 commit into
Conversation
portalocker is now on 4.x. According to its changelog and migration guide[0], the breaking changes are minimal, and it appears none of them impact msal-extensions as it doesn't use a shared lock (which would require explicitly adding a dependency on pywin32). 4.0+ requires Python 3.10 or greater, but since this only raises the upper bound of the dependency that isn't a problem. [0] https://portalocker.readthedocs.io/en/latest/migration.html Signed-off-by: Jeremy Cline <jeremycline@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
portalocker is now on 4.x. According to its changelog and migration guide[0], the breaking changes are minimal, and it appears none of them impact msal-extensions as it doesn't use a shared lock (which would require explicitly adding a dependency on pywin32).
4.0+ requires Python 3.10 or greater, but since this only raises the upper bound of the dependency that isn't a problem.
[0] https://portalocker.readthedocs.io/en/latest/migration.html