[okdistribute]

/bin/bash returns more consistent kill code than /bin/sh, but /bin/bash it isn't guaranteed to exist on all systems.

[max-mapper]

-1 to using sync method here. maybe just make the string an option that can be passed in, that way the user can choose their tradeoffs?

[AndreasMadsen]

Totally agree with @maxogden

child_process.exec supports a shell option:

I node core it is implemented like this:

  if (options && options.shell) {
    file = options.shell;
  }

I think execspawn should support that option too.

[okdistribute]

Sounds good

On Monday, January 4, 2016, Andreas Madsen notifications@github.com wrote:

Totally agree with @maxogden https://github.com/maxogden

child_process.exec supports a shell option
https://nodejs.org/api/child_process.html#child_process_child_process_exec_command_options_callback
:

I node core
https://github.com/nodejs/node/blob/master/lib/child_process.js#L96L97
it is implemented like this:

if (options && options.shell) {
file = options.shell;
}

I think execspawn should support that option too.

—
Reply to this email directly or view it on GitHub
#3 (comment)
.

Karissa McKelvey
http://karissa.github.io/

[okdistribute]

what would execspawn give differently than child_process.spawn then?

[AndreasMadsen]

Well the input API is child_process.exec and the output API is child_process.spawn so I don't see a problem there.

[okdistribute]

ok was just curious. going to close this and hopefully the kill bug will be fixed deeper in core