[deanq]

Summary

Some URLs were built from hardcoded hosts and so ignored the existing host overrides:

Where	Was	Now
rp console links (rp_cli/console.py)	console.runpod.io	RUNPOD_CONSOLE_URL
Login URL (apps/auth.py)	RUNPOD_CONSOLE_URL, read once at import	RUNPOD_CONSOLE_URL, read on each call
Task calls (apps/tasks.py)	<pod>-8080.proxy.runpod.net	RUNPOD_PROXY_DOMAIN (new)
rp pod get URLs (rp_cli/pod.py)	proxy.runpod.net	RUNPOD_PROXY_DOMAIN
rp endpoint run load-balancer fallback (rp_cli/endpoint.py)	<id>.api.runpod.ai	host of RUNPOD_ENDPOINT_BASE_URL

All of these now go through a small runpod/_hosts.py module: console_url(), proxy_url() and endpoint_domain(). It reads the env vars on each call, so a value set after import runpod still takes effect. Blank values fall back to the defaults. apps/targets._lb_domain now uses the same helper.

With none of these env vars set, every URL is the same as before.

Test plan

• New tests/test_hosts.py: defaults, overrides, and blank values falling back to the default
• One test per call site that sets the override and checks the resulting URL. Each failed before the change.
• make quality-check: 2746 passed, 94.29% coverage; runpod/_hosts.py at 100%

[Copilot]

🟡 Changes recommended

Endpoint URL resolution uses a stale host when the environment variable changes after import and produces malformed URLs when its initial value is blank.

1 open issue

• Read and normalize the endpoint base URL at call time · New

What changed in this PR

This PR centralizes service-host resolution so CLI links, login URLs, task requests, and endpoint fallbacks can use configurable hosts rather than hardcoded public domains.

Changes:

• Adds shared helpers for console URLs, proxy URLs, and endpoint domains.
• Updates CLI and app call sites to use those helpers.
• Adds helper and call-site tests for host overrides and default behavior.

File	Description
tests/​test_hosts.py	Tests host helpers, defaults, and overrides.
tests/​test_cli/​test_pod_command.py	Tests proxy overrides in pod URLs.
tests/​test_cli/​test_endpoint_command.py	Tests the configured load-balancer fallback domain.
tests/​test_cli/​test_console.py	Tests console-link overrides.
tests/​test_apps/​test_tasks.py	Tests task proxy-domain overrides.
tests/​test_apps/​test_auth.py	Tests call-time console overrides for login.
runpod/​rp_cli/​pod.py	Uses the shared proxy URL helper.
runpod/​rp_cli/​endpoint.py	Derives the load-balancer fallback domain.
runpod/​rp_cli/​console.py	Builds endpoint links from the console helper.
runpod/​apps/​tasks.py	Uses configurable task proxy URLs.
runpod/​apps/​targets.py	Delegates endpoint-domain resolution to the shared helper.
runpod/​apps/​auth.py	Resolves the console URL when generating login links.
runpod/​_hosts.py	Introduces shared service-host helpers.

_{Review effort: Balanced}

[briandconnelly]

Fixes recommended before merge.

Endpoint host resolution should be fixed because it does not provide the advertised call-time overrides or blank-value defaults. Tests were read, not run.

⚠️ Worth fixing

• Resolve endpoint overrides at call time with defaults
  _{Runtime overrides still direct fallback calls to the public service, while blank configurations break load-balanced calls lacking requestUrls.base.}

What changed

The pull request centralizes console, pod proxy, and endpoint domain resolution in runpod/_hosts.py and updates SDK and CLI call sites to use it. It adds helper and call-site tests for host overrides.

👾 Reviewed by review-agent (GPT-6.1 Sol) on behalf of briandconnelly

Commit 94ebfe0 · 1 inline comment

[KAJdev]

should have a document or notion doc or something internal with a snippet to easily switch between dev and prod hosts